Skip to content

Add InMemoryTransport #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

twenzel
Copy link

@twenzel twenzel commented Mar 29, 2025

This PR adds a third server transport: InMemoryServerTransport.

Motivation and Context

It can be used for testing or other special scenarios. Due to the fact, that McpServer requires a registered IServerTransport we need to provide at least a "dumb" one.

@twenzel twenzel force-pushed the feature/ProvideInMemoryTransport branch from e50bdca to 1f51437 Compare March 29, 2025 16:34
Copy link
Contributor

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks like you might have missed some of the conversation in #97 (comment)

Please hold off on more work until we've updated the transport interfaces. The IServerTransport in particular is changing to support multiple sessions. You can expect a PR with the interface changes later today.

@halter73
Copy link
Contributor

#142 is the PR that updates the IServerTransport interface. Please take a look.

@stephentoub
Copy link
Contributor

Thanks for your interest here, @twenzel. @halter73 has changed the interfaces, and I'm currently in the middle of refactoring out stream-based transports from the stdio ones. Given that, I don't think we're going to need separate in-memory transports. I'll close this, and if after that lands we decide we still need something more, we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants